-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create a verify_decoded_mpt_node
for a circuit
#284
Open
hidenori-shinohara
wants to merge
47
commits into
main
Choose a base branch
from
hide/decode-verification-circuit-succinct
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
89b6731
add a preliminary set of logic for verifying decoded lits.
hidenori-shinohara 28aefe0
Add logic for MPTVariable and one simple test that passes
hidenori-shinohara 5ccba6d
Start using MPTVariable in DecodeHint, tests do not pass yet.
hidenori-shinohara e782c52
Split the circuit into `decode_mpt_node` and `verify_decoded_mpt_node…
hidenori-shinohara 69f6cd7
Remove LIST_LEN since it's getting quite confusing
hidenori-shinohara 0dab5d8
Add a simple test for verify_decoded_mpt_node
hidenori-shinohara 3ae1bb2
Implement MPTVariable::elements<F> and add a test
hidenori-shinohara cd35c37
Add a new definition for `MPTVariable` using the `CircuitVariable` tr…
hidenori-shinohara 7917919
Remove the MPTVariable definition, as we already have one with the Ci…
hidenori-shinohara c957691
Remove the remaining references to the old MPTVariable that I just de…
hidenori-shinohara 07e0026
Fix `test_verify_decoded_mpt_node` so now it fails as expected. (I ha…
hidenori-shinohara 24da8c9
Finish writing the logic for `verify_decoded_mpt_node`. The test fail…
hidenori-shinohara 70bbe79
Add `watch` to visually compare the expected value and the actual out…
hidenori-shinohara 64d8dd6
clean up the logging statements
hidenori-shinohara feeb37f
Continue to work on verify_decode_mpt_node. Fix some obvious bugs and…
hidenori-shinohara 8a56258
Highlight some important comments about temporary changes since we ca…
hidenori-shinohara 8ad1ce1
Update stuff in both the non-circuit verification logic/tests and the…
hidenori-shinohara 7027696
Readability commit. Add more comments and update some variable names.…
hidenori-shinohara d12cec3
Fix an obvious bug. Tests still fail.
hidenori-shinohara 2ac02c0
I am aware of a few more issues, but if challenger = 1, the tests pas…
hidenori-shinohara c993ab1
Start working on a different abstraction `calculate_polynomial_emulat…
hidenori-shinohara d701674
My first pass of calculate_polynomial_emulating_rlp_encoding, tests s…
hidenori-shinohara f32dd03
Tests pass when challenger = 1. Tests fail when challenger != 1. Indi…
hidenori-shinohara c8e6146
Fix a signficant bug on powers. Not all tests pass yet.
hidenori-shinohara d771521
All tests pass. This fixes a bug and removes debugging statements. Te…
hidenori-shinohara fdc26dd
Add a "negative" test that is expected to fail.
hidenori-shinohara 1e1d9ee
Readability
hidenori-shinohara 6953b4d
factor out the prefix-shift logic
hidenori-shinohara 08e1e2c
I found a bug, and this commit adds a test case
hidenori-shinohara 86114bc
This now works with case 1 (<= 55 bytes) and case 2 (<= 255 bytes). c…
hidenori-shinohara 0d2414c
Fix bugs, now all tests seem to pass
hidenori-shinohara fd23111
Clean up the unused imports
hidenori-shinohara 8702eaa
clean up comments
hidenori-shinohara ee4b81b
add a simple test for single bytes
hidenori-shinohara 4a9d4ef
Add div_rem to U32Variable
hidenori-shinohara 71c62f5
Clean up the div_mod operation with the newly implemented function fr…
hidenori-shinohara 039b945
Add `calculate_polynomial_emulating_rlp_encoding_cubic` but I don't u…
hidenori-shinohara d33f5d8
Tests pass with CubicElement
hidenori-shinohara c2c57cd
Adds random_seeds to CircuitBuilder
hidenori-shinohara afc1984
seeds seem to be working!
hidenori-shinohara b6aba48
Remove the seed code as we already have the challenger that takes the…
hidenori-shinohara 8a28f32
Make sure that we observe all the inputs for the decode verification
hidenori-shinohara 1187979
Remove the loop which is now unnecessary since we have a cubic extens…
hidenori-shinohara 1f4b28d
Remove unused imports
hidenori-shinohara e3d6f3e
minor cleanups
hidenori-shinohara 5481057
Minor typos
hidenori-shinohara fdec6dd
Clean up a TODO
hidenori-shinohara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is cleaner lol