Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Regression test for all_introns_counts_and_info.py #62

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

ns-rse
Copy link
Contributor

@ns-rse ns-rse commented Nov 21, 2024

A basic regression test that checks the results are the same on running.

This will allow me to start refactoring the codebase as I can ensure I get the same result as I tinker with the code.

Adds a bunch of input files to tests/resources/* although many of these are input to the full pipeline it is useful to have for this minimal reproducible example.

There is I think a need to separate the overall pipeline of processing raw output (undertaken by
pipeline_slam_3UIs.py) from the actual key analysis that IsoSLAM (the code in
isoslam/all_introns_conuts_and_info.py).

I think it would be worth discussing whether we want the pipeline which relies heavily on cgat to be part of the package, or whether we write instructions and provide examples of how to get to the input stage. When @IanSudbery and I chatted last week I think it was mentioned that the preparation of files is something Bioinformaticians would be familiar with.

Adds a bunch of input files to `tests/resources/*` although many of these are input to the full pipeline it is useful to
have for this minimal reproducible example.

There is I think a need to separate the overall pipeline of processing raw output (undertaken by
`pipeline_slam_3UIs.py`) from the actual key analysis that IsoSLAM (the code in
`isoslam/all_introns_conuts_and_info.py`).
A basic regression test that checks the results are the same on running.

This will allow me to start refactoring the codebase as I can ensure I get the same result as I tinker with the code.
@ns-rse ns-rse added the tests Testing issues label Nov 21, 2024
Also attempting to install these dependencies before installing isoslam and its test dependencies.
@ns-rse ns-rse merged commit e12e78d into main Nov 21, 2024
0 of 14 checks passed
@ns-rse ns-rse deleted the ns-rse/45-minimal-reprex branch November 21, 2024 16:40
@ns-rse ns-rse restored the ns-rse/45-minimal-reprex branch November 21, 2024 17:59
@ns-rse ns-rse mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Testing issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant