[super_editor_markdown] Fix compilation error #2406
Conversation
| @@ -49,6 +49,10 @@ Future<void> pasteMarkdown({ | |||
| selection: composer.selection!, | |||
| ); | |||
|
|
|||
| if (pastePosition == null) { | |||
There was a problem hiding this comment.
Shouldn't this guard clause appear directly below the pastePosition assignment? In what situation can we paste without a selection?
There was a problem hiding this comment.
The first assignment is assumed to be always non-null. I added the nullability annotation because CommonEditorOperations.getDocumentPositionAfterExpandedDeletion can return null.
There was a problem hiding this comment.
It looks like you could use the base and not re-assign it. But I'm guessing you don't do that because there might be non-deletable nodes?
Aside from the return type, in what situation would deletion return a null selection?
There was a problem hiding this comment.
Aside from the return type, in what situation would deletion return a null selection?
It returns null if there are only non-deletable nodes in the selection.
There was a problem hiding this comment.
It returns null if there are any non-deletable nodes in there at all? If so, why did we do that?
There was a problem hiding this comment.
Only if all nodes are non-deletable.
There was a problem hiding this comment.
Ok. Let's get rid of the pastePosition assignment at the top.
In the if-statement, declare the pastePosition where it's assigned to getDocumentPositionAfterExpandedDeletion.
After the if-statement, it looks like pastePosition is only referenced one time, which means we can replace pastePosition there with composer.selection!.extent.
Also, please add a comment in the if-statement that reminds the reader that the selection might be comprised exclusively if non-deletable nodes, and therefore the paste position might be null.
matthew-carroll
deleted the
fix_super_editor_markdown_compilation_error
branch
|
@angelosilvestre something went wrong with the cherry pick here. Can you do it manually? |
|
@matthew-carroll The changes were already included in #2422 |
[super_editor_markdown] Fix compilation error
Now
CommonEditorOperations.getDocumentPositionAfterExpandedDeletionreturns a nullable type. This caused a compilation error inpasteMarkdown.This PR fixes that issue.