Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[super_editor_markdown] Fix compilation error #2406

Merged
merged 2 commits into from
Nov 30, 2024
Merged

[super_editor_markdown] Fix compilation error #2406

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbad179
[super_editor_markdown] Fix compilation error
angelosilvestre Nov 13, 2024
38d9170
PR updates
angelosilvestre Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion super_editor_markdown/lib/src/super_editor_paste_markdown.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Future<void> pasteMarkdown({
required Document document,
required DocumentComposer composer,
}) async {
DocumentPosition pastePosition = composer.selection!.extent;
DocumentPosition? pastePosition = composer.selection!.extent;

// Delete all currently selected content.
if (!composer.selection!.isCollapsed) {
Expand All @@ -49,6 +49,10 @@ Future<void> pasteMarkdown({
selection: composer.selection!,
);

if (pastePosition == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this guard clause appear directly below the pastePosition assignment? In what situation can we paste without a selection?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first assignment is assumed to be always non-null. I added the nullability annotation because CommonEditorOperations.getDocumentPositionAfterExpandedDeletion can return null.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you could use the base and not re-assign it. But I'm guessing you don't do that because there might be non-deletable nodes?

Aside from the return type, in what situation would deletion return a null selection?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the return type, in what situation would deletion return a null selection?

It returns null if there are only non-deletable nodes in the selection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns null if there are any non-deletable nodes in there at all? If so, why did we do that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if all nodes are non-deletable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Let's get rid of the pastePosition assignment at the top.

In the if-statement, declare the pastePosition where it's assigned to getDocumentPositionAfterExpandedDeletion.

After the if-statement, it looks like pastePosition is only referenced one time, which means we can replace pastePosition there with composer.selection!.extent.

Also, please add a comment in the if-statement that reminds the reader that the selection might be comprised exclusively if non-deletable nodes, and therefore the paste position might be null.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

return;
}

// Delete the selected content.
editor.execute([
DeleteContentRequest(documentRange: composer.selection!),
Expand Down
Loading