-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry Pick: Bump dependencies (Resolves #2336) #2422
Cherry Pick: Bump dependencies (Resolves #2336) #2422
Conversation
@angelosilvestre can you take a look at these failures due to dependency changes? |
@matthew-carroll It seems the super_editor dev version was outdated on stable. |
@angelosilvestre can you let me know which references exactly are out of date? I see you brought back dependency overrides for super_editor within the Markdown package. What are we missing in the Pub release of super_editor that our Markdown package needs? |
@matthew-carroll The super_editor version was 0.3.0-dev.6 on stable and 0.3.0-dev.10 on main. The super_editor_markdown package is referencing 0.3.0-dev.10. |
...so why are we still using dependency overrides on stable? |
It seems like its using the version from dependency_overrides, but validating against the version declared in the depencencies section. |
e152bf2
to
c64f647
Compare
c64f647
to
a8b6a6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry Pick: Original PR - #2420