Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick: Bump dependencies (Resolves #2336) #2422

Conversation

github-actions[bot]
Copy link

Cherry Pick: Original PR - #2420

@matthew-carroll
Copy link
Contributor

@angelosilvestre can you take a look at these failures due to dependency changes?

@angelosilvestre
Copy link
Collaborator

@matthew-carroll It seems the super_editor dev version was outdated on stable.

@matthew-carroll
Copy link
Contributor

@angelosilvestre can you let me know which references exactly are out of date? I see you brought back dependency overrides for super_editor within the Markdown package. What are we missing in the Pub release of super_editor that our Markdown package needs?

@angelosilvestre
Copy link
Collaborator

@matthew-carroll The super_editor version was 0.3.0-dev.6 on stable and 0.3.0-dev.10 on main. The super_editor_markdown package is referencing 0.3.0-dev.10.

@matthew-carroll
Copy link
Contributor

The super_editor version was 0.3.0-dev.6 on stable and 0.3.0-dev.10 on main. The super_editor_markdown package is referencing 0.3.0-dev.10.

...so why are we still using dependency overrides on stable?

@angelosilvestre
Copy link
Collaborator

...so why are we still using dependency overrides on stable?

It seems like its using the version from dependency_overrides, but validating against the version declared in the depencencies section.

@angelosilvestre angelosilvestre force-pushed the cherry-pick_2336_bump-dependencies_646d26fa338d69c9c03b0eab2cc3c41983b66512 branch from e152bf2 to c64f647 Compare November 27, 2024 22:13
@angelosilvestre angelosilvestre force-pushed the cherry-pick_2336_bump-dependencies_646d26fa338d69c9c03b0eab2cc3c41983b66512 branch from c64f647 to a8b6a6a Compare November 27, 2024 22:14
Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit cb26908 into stable Nov 30, 2024
11 checks passed
@matthew-carroll matthew-carroll deleted the cherry-pick_2336_bump-dependencies_646d26fa338d69c9c03b0eab2cc3c41983b66512 branch November 30, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants