Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updating Contributing Requirements #116

Merged
merged 4 commits into from
Jan 1, 2024
Merged

docs: Updating Contributing Requirements #116

merged 4 commits into from
Jan 1, 2024

Conversation

prateek3255
Copy link
Contributor

@prateek3255 prateek3255 commented Dec 29, 2023

Summary of change

  • Update Node version requirement
  • Add a step in tests to add a static entry for localhost.org
  • Remove the conflicting eslint and prettier files for TestingApp

Related issues

N/A

Test Plan

N/A

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

N/A

Copy link

github-actions bot commented Dec 29, 2023

size-limit report 📦

Path Size
lib/build/index.js 24.38 KB (0%)

@prateek3255 prateek3255 changed the title docs: Update the requirements in docs and remove conflicting linting config docs: Update the requirements in docs Dec 29, 2023
@prateek3255 prateek3255 changed the title docs: Update the requirements in docs docs: Updating requirements Dec 29, 2023
@prateek3255 prateek3255 marked this pull request as ready for review December 29, 2023 13:13
@prateek3255 prateek3255 changed the title docs: Updating requirements docs: Updating Contributing Requirements Dec 29, 2023
TestingApp/.prettierrc.js Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@prateek3255 prateek3255 changed the title docs: Updating Contributing Requirements chore: Updating Contributing Requirements Jan 1, 2024
@prateek3255 prateek3255 changed the title chore: Updating Contributing Requirements docs: Updating Contributing Requirements Jan 1, 2024
@rishabhpoddar rishabhpoddar merged commit 7d32ca1 into 4.0 Jan 1, 2024
4 checks passed
@rishabhpoddar rishabhpoddar deleted the docs-update branch January 1, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants