Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updating Contributing Requirements #116

Merged
merged 4 commits into from
Jan 1, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ We're so excited you're interested in helping with SuperTokens! We are happy to
## Development Setup
rishabhpoddar marked this conversation as resolved.
Show resolved Hide resolved

### Prerequisites
- Nodejs & npm
- **Node.js v16.x** & npm
- IDE: [VSCode](https://code.visualstudio.com/download)(recommended) or equivalent IDE

### Project Setup
Expand Down Expand Up @@ -55,11 +55,12 @@ We're so excited you're interested in helping with SuperTokens! We are happy to
cp -r ./test/tough-cookie ./node_modules/
npm i git+https://github.com:<your username>/supertokens-react-native.git
```
5. Navigate to `supertokens-react-native/TestingApp` and run all tests
5. Add a static entry for `127.0.0.1 localhost.org` in your `/etc/hosts` file
6. Navigate to `supertokens-react-native/TestingApp` and run all tests
```
INSTALL_PATH=../../supertokens-root npm test
```
6. If all tests pass the output should be:
7. If all tests pass the output should be:

<img src="https://github.com/supertokens/supertokens-logo/blob/master/images/supertokens-react-native-tests-passing.png" alt="React Native tests passing" width="500px">

Expand Down
4 changes: 0 additions & 4 deletions TestingApp/.eslintrc.js

This file was deleted.

7 changes: 0 additions & 7 deletions TestingApp/.prettierrc.js

This file was deleted.

8 changes: 4 additions & 4 deletions examples/with-thirdparty/babel.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = function(api) {
api.cache(true);
return {
presets: ['babel-preset-expo'],
};
api.cache(true);
return {
presets: ["babel-preset-expo"]
};
};
Loading