This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Configure kernel provisioner and default environment file #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diocas
reviewed
May 17, 2022
| for key, val in dict(os.environ).items(): | ||
| if key == "SUDO_COMMAND": | ||
| continue | ||
| if key == "PYTHONPATH": |
There was a problem hiding this comment.
This env file is going to be used by the kernels as well, right? Please note that you're not setting the same environment as before. We removed this extra path from the file that is loaded from the terminal, but it is supposed to exist in the kernel (otherwise, the spark stuff will break).
diocas
reviewed
May 17, 2022
| @@ -124,7 +124,14 @@ import json | |||
|
|
|||
| def addEnv(dtext): | |||
There was a problem hiding this comment.
This code exists here to be able to retrieve the user environment. If you no longer need to get it and write it in the kernel.json file, I would move it to the logic where we set the kernels (when we copy them from cvmfs). It would be more logical to do everything together there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for swan-cern/jupyter-extensions#252