This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Configure kernel provisioner and default environment file #81
Draft
krishnan-r
wants to merge
1
commit into
master
Choose a base branch
from
swanprojects-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,7 +124,14 @@ import json | |
|
||
def addEnv(dtext): | ||
d=eval(dtext) | ||
d["env"]=dict(os.environ) | ||
|
||
# Configure a provisioner in kernel.json, that will load the enviornment | ||
# dynamically from a folder-specific file or the default enviornment file | ||
d["metadata"] = { | ||
"kernel_provisioner": { | ||
"provisioner_name": "swan-provisioner" | ||
} | ||
} | ||
return d | ||
|
||
kdirs = os.listdir("$KERNEL_DIR") | ||
|
@@ -141,6 +148,15 @@ with open("$SWAN_ENV_FILE", "w") as termEnvFile: | |
if key == "PYTHONPATH": | ||
val = re.sub('/usr/local/lib/swan/(extensions/)?:', '', val) | ||
termEnvFile.write("export %s=\"%s\"\n" % (key, val)) | ||
# Write an enviornment file to be read by the provisioner | ||
# for folders without a defined environment | ||
with open("$SWAN_DEFAULT_ENV_FILE", "w") as defaultEnvFile: | ||
for key, val in dict(os.environ).items(): | ||
if key == "SUDO_COMMAND": | ||
continue | ||
if key == "PYTHONPATH": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This env file is going to be used by the kernels as well, right? Please note that you're not setting the same environment as before. We removed this extra path from the file that is loaded from the terminal, but it is supposed to exist in the kernel (otherwise, the spark stuff will break). |
||
val = re.sub('/usr/local/lib/swan/(extensions/)?:', '', val) | ||
defaultEnvFile.write("%s=%s\n" % (key, val)) | ||
EOF | ||
|
||
# Make sure that `python` points to the correct python bin from CVMFS | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code exists here to be able to retrieve the user environment. If you no longer need to get it and write it in the kernel.json file, I would move it to the logic where we set the kernels (when we copy them from cvmfs). It would be more logical to do everything together there.