[lld] Disable ability to link Mach-O for Darwin platforms (but not non-Darwin firmware) in Swift LLVM fork #8119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
shahmishal,
airspeedswift,
rauhul and
fredriss
rauhul
reviewed
Feb 3, 2024
…n-Darwin firmware) in Swift LLVM fork
kubamracek
force-pushed
the
20230725-lld-no-macho
branch
from
893ef7f to
71ad316
Compare
kubamracek
changed the title
|
Changed this PR to not disable Mach-O linking completely, but only when building for Darwin userspace platforms. @rauhul does that seem reasonable now? |
|
@swift-ci please test |
This was referenced Mar 26, 2024
|
Apologies if I'm missing something, but how would one go about doing a Linux -> Darwin cross link after this commit? Prior to this |
|
Hi folks, I created a PR to update this check to only abort on Darwin hosts. Would appreciate your review! #9698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Embedded Swift, we want to start including lld even in Darwin toolchains to be able to link ELF files even on Darwin, see swiftlang/swift#70715. To avoid accidentally using lld to link Mach-O files, let's disable this ability in the Apple fork of llvm-project. Linking Mach-Os is only supported using the Xcode-provided Darwin linker (ld/ld64).