[Markdown] Contributing: Add section about release branch PRs #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
shahmishal,
cthielen and
federicobucchi
as code owners
This was referenced Jun 4, 2024
Merged
|
cc @shahmishal. |
0xTim
reviewed
Jun 4, 2024
contributing/_contributing-code.md
Outdated
| @@ -111,6 +111,55 @@ For C or C++ source or header files, the code header should look this: | |||
|
|
|||
| The divider lines should be exactly 80 characters wide to aid in adherence to the code style guidelines. The bottom section contains an optional description intended for generated documentation (these lines begin with `///` rather than `//`). If there is no description, this area can be skipped. | |||
|
|
|||
| ### Release Branch Pull Requests | |||
|
|
|||
| *All changes* to a release branch (`release/x.y`) must be nominated through pull | |||
There was a problem hiding this comment.
What's a nomination in this instance? Does it mean that you have to suggest your code for inclusion in a different forum before a PR can be opened or would
Suggested change
| *All changes* to a release branch (`release/x.y`) must be nominated through pull | |
| *All changes* to a release branch (`release/x.y`) must be done through pull |
Be a better description
There was a problem hiding this comment.
Nominated in the sense of proposed, but I’m happy to use "done" if you think it’s more apt. Let me have another go at rewording this to be crystal clear.
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
08f057b
to
7717960
Compare
ahoppen
reviewed
Jun 4, 2024
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
7717960
to
4884102
Compare
AnthonyLatsis
commented
Jun 5, 2024
contributing/_contributing-code.md
Outdated
Comment on lines
139
to
140
| - **Reviewers**: The code owners that approved the mainline branch pull | ||
| requests. If any part of the mainline branch changes was not approved by a | ||
| respective code owner, provide a reason. Technical review can be delegated | ||
| by a code owner or otherwise requested as deemed appropriate or useful. |
There was a problem hiding this comment.
Second sentence amended per swiftlang/swift#72722 (comment). I would really like to add some clarity to that last sentence too, but that can wait.
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
4884102
to
063d7d7
Compare
AnthonyLatsis
commented
Jun 5, 2024
AnthonyLatsis
force-pushed
the
prunus-persica
branch
2 times, most recently
from
b7c3c4f
to
62421ad
Compare
finagolfin
reviewed
Jun 12, 2024
finagolfin
approved these changes
Jun 12, 2024
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
62421ad
to
43a80d1
Compare
|
Small change of plans: the form now lives in swiftlang/.github as a pull request template, so no need to inline it here. |
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
43a80d1
to
e22d942
Compare
AnthonyLatsis
force-pushed
the
prunus-persica
branch
2 times, most recently
from
293efe1
to
a63b862
Compare
|
Friendly ping, fellows. |
In an effort to centralize information about the release process, including guidance on formatting a release branch pull request, dedicate a section to this for repositories and forum announcements to refer to.
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
a63b862
to
0b8db2c
Compare
|
@swift-ci test |
|
@0xTim Could we get an approval too to unblock merging? Thanks. 🙂 |
0xTim
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In an effort to centralize information about the release process, including guidance on formatting a release branch pull request, dedicate a section to this for repositories and forum announcements to refer to.
Modifications:
—
Result:
—