[NFC] Delete release branch PR template in favor of org-wide variant #2669
Conversation
There was a problem hiding this comment.
Thank you. Guess I now also need to update sourcekit-lsp again, where I just added the templates 😆 swiftlang/sourcekit-lsp@b844dd3
.github/pull_request_template.md
Outdated
There was a problem hiding this comment.
I’d prefer not to have this in the pull request template. Almost all PRs, especially from contributors are targeting the main branch and so this doesn’t apply and would be noise.
There was a problem hiding this comment.
At your discretion. FWIW, the idea is to provide quick access to the form (as a workaround to not being able to automate the template selection).
There was a problem hiding this comment.
As an aside, I got curious and did the math: ~13% (swift-syntax) vs. ~43% (swift) PRs targeting release branches.
There was a problem hiding this comment.
I think a major point for me is that it’s a different target audience. In my opinion the templates are particularly valuable for newcomers. But contributors contributing to release branches are usually seasoned.
How exactly did you measure that? 43% to release branches seems a little high to me. That basically means that every PR to main has a corresponding PR to a release branch, which can’t be the case since some time of the year there is not release branch to cherry-pick the changes to.
There was a problem hiding this comment.
Good judgement — I forgot about master. With master it is ~11% vs. ~17%.
There was a problem hiding this comment.
OK, that makes a lot more sense. Thanks for clarifying. I stick with my opinion of not including it in the PR template though 😉
There was a problem hiding this comment.
Oh, sure, I’m happy to take your word for what works best for swift-syntax. The numbers were not to prove a point, I just felt like sharing the info. 🙂
There was a problem hiding this comment.
Those were really interesting numbers. I would hav personally expected them to be quite a bit lower. Showed that I was wrong 😄
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
4bb0bba
to
9b07c49
Compare
How is this issue template related, though? 😅 |
Ah, I see, you meant this commit. |
AnthonyLatsis
changed the title
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
9b07c49
to
6962908
Compare
AnthonyLatsis
changed the title
AnthonyLatsis
changed the title
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
6962908
to
5128ee3
Compare
|
I will amend the doc to point to the website once swiftlang/swift-org-website#688 is merged. |
CONTRIBUTING.md
Outdated
| ``` | ||
| https://github.com/swiftlang/swift-syntax/compare/main...my-branch?quick_pull=1&template=release.md | ||
| ``` |
There was a problem hiding this comment.
If we wanna visual the change in the URL we can use diff code block here:
| ``` | |
| https://github.com/swiftlang/swift-syntax/compare/main...my-branch?quick_pull=1&template=release.md | |
| ``` | |
| ```diff | |
| - https://github.com/swiftlang/swift-syntax/compare/main...my-branch?quick_pull=1 | |
| + https://github.com/swiftlang/swift-syntax/compare/main...my-branch?quick_pull=1&template=release.md |
Not sure if that will be useful–it just come to my mind so adding a suggestion 🫶
There was a problem hiding this comment.
I think it a lovely idea. Thanks!
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
5128ee3
to
8099b8a
Compare
`swiftlang` now has an equivalent organization-wide PR template, so we no longer need this local one.
AnthonyLatsis
force-pushed
the
prunus-persica
branch
from
8099b8a
to
e42963d
Compare
|
@swift-ci Please test |
|
@swift-ci please test Windows |
swiftlangnow has an equivalent organization-wide PR template, so we no longer need this local one.