Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan_route_plugin: waypoints_ relative to target_frame #554

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

facontidavide
Copy link
Contributor

@facontidavide facontidavide commented Dec 13, 2017

Hi,

this modification of plan_route_plugin is mostly related to code simplification.

  1. waypoints will contain poses relative to target_frame_, not stu::_wgs84_frame. This greatly reduces the need for tf_manager_.GetTransform() in many locations of the file, making it more readable.

  2. Only inside the method PlanRoute() the conversion from target_frame_ to stu::_wgs84_frame is done.

  3. if the latter transform fails, the mnm::PlanRoute is still send, with:

      plan_route.request.header.frame_id = target_frame_;
    

but maybe you do NOT want to do this...

  1. Similarly, in Draw(), if this fails

     tf_manager_.GetTransform(stu::_wgs84_frame, target_frame_, transform)
    

a straight line is drawn instead. Personal taste I guess.
Since I don't have the PlanRoute server, I am not able to thoughtfully test it, though.

UPDATE: of course I did test 90% of these changes on my own fork, but I am unable to properly check anything related to the Route server

Davide

@pjreed pjreed changed the base branch from kinetic-devel to master November 12, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant