Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical coordinates for spherical harmonic mesh #6389

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

kidder
Copy link
Member

@kidder kidder commented Nov 28, 2024

Proposed changes

Computes the logical coordinates for a spherical harmonic basis

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Comment on lines 68 to 71
case Spectral::Basis::Chebyshev:
// fall through
case Spectral::Basis::Legendre:
// fall through
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

nilsdeppe
nilsdeppe previously approved these changes Dec 4, 2024
nilsvu
nilsvu previously approved these changes Dec 5, 2024
@nilsvu nilsvu enabled auto-merge December 6, 2024 18:57
@nilsvu nilsvu merged commit 05a26c2 into sxs-collaboration:develop Dec 6, 2024
23 checks passed
@kidder kidder deleted the spherical_mesh branch December 10, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants