Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json and travis configs #63

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

dnsl48
Copy link
Contributor

@dnsl48 dnsl48 commented Nov 11, 2019

@Cheddam
Copy link

Cheddam commented Nov 12, 2019

@dnsl48 Looks like the PGSQL build is failing - perhaps a recent change to the PostgreSQL module broke something? Worth confirming before we merge this.

@dnsl48
Copy link
Contributor Author

dnsl48 commented Nov 12, 2019

Well, the build is using the latest stable postgres driver. I think it might be worth having the broken build. Otherwise, I'm not sure the last pg builds (which ran 4 months ago) are gonna be green if we rerun them now.

Copy link

@Cheddam Cheddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further investigation, we've discovered that the PostgreSQL tests haven't actually been running, as the related matrix item in .travis.yml does not trigger the unit tests (this PR will fix that). We'll raise a separate issue to address the PostgreSQL breakage and ensure that the current major (5) branch that will be created shortly has correct coverage.

@dnsl48
Copy link
Contributor Author

dnsl48 commented Nov 13, 2019

Follow up issue - #64

@robbieaverill
Copy link
Contributor

robbieaverill commented Nov 13, 2019

My suggestion would be to not add Travis changes that don't work and merge anyway, but include them in your follow up PR (skim read this PR - feel free to ignore if you're all over it already)

@Cheddam
Copy link

Cheddam commented Nov 13, 2019

@robbieaverill Not quite sure what you mean - is it not better to get the tests running correctly and red, than to leave them only half running and green? It gives us accurate visibility of the state of the module, even if we can't address the failure immediately.

@robbieaverill
Copy link
Contributor

robbieaverill commented Nov 13, 2019

Perhaps adding support for Postgres is a feature in some cases, if it were designed for MySQL originally (not sure about this module). Up to you, but you could easily leave the builds green and add a new PR with also green builds - that would be my preference :)

@dnsl48
Copy link
Contributor Author

dnsl48 commented Nov 13, 2019

ok, removing tests for the time being - #66
when pg works (fixed) we can get them back

@Cheddam
Copy link

Cheddam commented Nov 13, 2019

PostgreSQL issue is at #67.

@Cheddam Cheddam merged commit 19f2603 into symbiote:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants