Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sf7 declaration incompatibility error fix #115

Closed
wants to merge 1 commit into from

Conversation

hgabka
Copy link

@hgabka hgabka commented Jan 12, 2024

This fixes the Declaration incompatibility error in AclVoter class.

@mareklauko
Copy link

not a good solution as a lot of parent packages requered for PHP 7 which does not know mixed input type, but I did same way, there is need to update security-acl/composer.json, too and require PHP >=8

fabpot added a commit that referenced this pull request Oct 18, 2024
This PR was merged into the 3.x-dev branch.

Discussion
----------

Fix Symfony 7 compatibility

Continuation of #116

I want to see what is failing to fix it.

Might close: #112 #115 #114 #121

Commits
-------

17f2255 Actualizar AclVoter.php
29379e6 fix cs issues
c4c7ca0 suppress psalm since it is not fixable
1247ccb Fix tests
8647e14 Fix symfony 7 compatibility
@fabpot fabpot closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants