Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #16

Merged
merged 46 commits into from
Jul 25, 2022
Merged

Various improvements #16

merged 46 commits into from
Jul 25, 2022

Conversation

nordlow
Copy link
Contributor

@nordlow nordlow commented Jul 20, 2022 •
edited
Loading

Can you please tell me how you want this split up, @burner?

FYI, @skoppe.

Per Nordlöw and others added 28 commits December 10, 2021 20:16
Ignore libxlsxreader.a
c7ca668
Qualify all Cell members starting with convertTo as const
6dff694
Ignore dub.selections.json
6169aee
@nordlow
Qualify all Cell members starting with convertTo as @trusted
2b37c80
@nordlow
Add overload of getRow that defaults end to start + 1
2d85223
@nordlow
Rename start and end to more descriptive names and default init them …
01bab67 
…to 0 and size_t.max when releveant
@nordlow
Remove unused import
e6c64fc
@nordlow
Qualify members of xlsxreader
cda0f60
@nordlow
Set default values for RowUntyped parameters
c278cb1
@nordlow
Qualify all empty
615544e
@nordlow
Set default parameters of Row.this()
4acfec5
@nordlow
Qualify all save() members
ecaf75a
@nordlow
Initialize ColumnUntyped and Column parameters
b0e576b
@nordlow
Add asserts to RowUntyped and ColumnUntyped
e04d3af
@nordlow
Expose Iterator as a an array via alias this
cc7928e
@nordlow
Add Iterator.array
e2b2a85
@nordlow
Add TODO
6840578
@nordlow
Qualify some parameters and members as const or in
64c88a2
@nordlow
Use typeof(return) in Cell members
1955e3d
@nordlow
Add dep to mir-core
57d3d00
@nordlow
Add TODO about using mir.algebraic
bb31b78
@nordlow
Add TODO
1126d6c
@nordlow
Correct parameter namings
53479ba
@nordlow
Replace in size_t with size_t
23a2371
@nordlow
Make iterateRow @trusted for now to make build pass
49d52e3
@nordlow
Bump mir-core to 1.1.109 in dub.json
28ee707
@nordlow
Convert dub.json to dub.sdl
66ba299
@nordlow
Merge remote-tracking branch 'upstream/master' into fix-compilation-2…
c202167 
…022-07-20
@nordlow nordlow force-pushed the fix-compilation-2022-07-20 branch from ab957a5 to c202167 Compare July 20, 2022 13:56
burner
burner reviewed Jul 20, 2022
View reviewed changes
source/xlsxreader.d Outdated Show resolved Hide resolved
burner
burner reviewed Jul 20, 2022
View reviewed changes
dub.sdl Outdated Show resolved Hide resolved
burner
burner reviewed Jul 20, 2022
View reviewed changes
dub.sdl Outdated Show resolved Hide resolved
burner
burner reviewed Jul 20, 2022
View reviewed changes
source/xlsxreader.d Outdated Show resolved Hide resolved
@nordlow nordlow force-pushed the fix-compilation-2022-07-20 branch from c5f2bd8 to c8ec5bc Compare July 20, 2022 14:44
@nordlow
Copy link
Contributor Author

nordlow commented Jul 22, 2022 •
edited
Loading

Still using @safe: and a single @trusted unittest. Shall I convert @safe: to individual @safe-qualifications of (member) functions?

@burner
Copy link
Collaborator

burner commented Jul 22, 2022

Still using @safe: and a single @trusted unittest. Shall I convert @safe: to individual @safe-qualifications of (member) functions?

yes please

@nordlow
Copy link
Contributor Author

nordlow commented Jul 25, 2022 •
edited
Loading

Still using @safe: and a single @trusted unittest. Shall I convert @safe: to individual @safe-qualifications of (member) functions?

yes please

Done at b582ed0. Should be ready now, @burner.

@nordlow nordlow force-pushed the fix-compilation-2022-07-20 branch from b582ed0 to 7a00e54 Compare July 25, 2022 15:40
burner
burner reviewed Jul 25, 2022
View reviewed changes
source/xlsxreader.d Outdated Show resolved Hide resolved
@nordlow nordlow force-pushed the fix-compilation-2022-07-20 branch from f45a696 to a61facb Compare July 25, 2022 16:11
@burner burner merged commit b1c6fa9 into symmetryinvestments:master Jul 25, 2022
@nordlow
Copy link
Contributor Author

nordlow commented Jul 25, 2022

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burner burner burner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nordlow @burner