Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #16

Merged
merged 46 commits into from
Jul 25, 2022
Merged

Various improvements #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
c7ca668
Ignore libxlsxreader.a
Dec 10, 2021
6dff694
Qualify all Cell members starting with convertTo as const
Dec 10, 2021
6169aee
Ignore dub.selections.json
Dec 10, 2021
2b37c80
Qualify all Cell members starting with convertTo as @trusted
nordlow Dec 10, 2021
2d85223
Add overload of getRow that defaults `end` to `start + 1`
nordlow Feb 9, 2022
01bab67
Rename start and end to more descriptive names and default init them …
nordlow Feb 10, 2022
e6c64fc
Remove unused import
nordlow Feb 11, 2022
cda0f60
Qualify members of xlsxreader
nordlow Feb 18, 2022
c278cb1
Set default values for RowUntyped parameters
nordlow Feb 18, 2022
615544e
Qualify all empty
nordlow Feb 18, 2022
4acfec5
Set default parameters of Row.this()
nordlow Feb 18, 2022
ecaf75a
Qualify all save() members
nordlow Feb 18, 2022
b0e576b
Initialize ColumnUntyped and Column parameters
nordlow Feb 18, 2022
e04d3af
Add asserts to RowUntyped and ColumnUntyped
nordlow Feb 21, 2022
cc7928e
Expose Iterator as a an array via alias this
nordlow Feb 21, 2022
e2b2a85
Add Iterator.array
nordlow Feb 21, 2022
6840578
Add TODO
nordlow Feb 21, 2022
64c88a2
Qualify some parameters and members as const or in
nordlow Feb 22, 2022
1955e3d
Use typeof(return) in Cell members
nordlow Feb 22, 2022
57d3d00
Add dep to mir-core
nordlow Feb 22, 2022
bb31b78
Add TODO about using mir.algebraic
nordlow Feb 22, 2022
1126d6c
Add TODO
nordlow Feb 22, 2022
53479ba
Correct parameter namings
nordlow Feb 22, 2022
23a2371
Replace in size_t with size_t
nordlow Feb 22, 2022
49d52e3
Make iterateRow @trusted for now to make build pass
nordlow Jul 15, 2022
28ee707
Bump mir-core to 1.1.109 in dub.json
nordlow Jul 15, 2022
66ba299
Convert dub.json to dub.sdl
nordlow Jul 20, 2022
c202167
Merge remote-tracking branch 'upstream/master' into fix-compilation-2…
nordlow Jul 20, 2022
22f975f
Revert "Convert dub.json to dub.sdl"
nordlow Jul 20, 2022
b43fc55
Remove dependency on mir-core in dub.json
nordlow Jul 20, 2022
a836854
Remove @trusted from unittest
nordlow Jul 20, 2022
86a3ce8
Remove TODO comment about using mir.algebraic
nordlow Jul 20, 2022
c89741a
Remove commented out debug code
nordlow Jul 20, 2022
0c96c4b
Remove old conversion code
nordlow Jul 20, 2022
429eab3
Remove TODO comment
nordlow Jul 20, 2022
537af6d
Adjust convertTo
nordlow Jul 20, 2022
c8ec5bc
Rename .value to .xmlValue
nordlow Jul 20, 2022
3dec85a
Put back @trusted qualifier for a single unittest
nordlow Jul 20, 2022
32ab1f4
Remove TODO
nordlow Jul 20, 2022
d7197f2
Rename xmlValue to value in insertValueIntoCell
nordlow Jul 20, 2022
2d2faf0
Revert "Rename xmlValue to value in insertValueIntoCell"
nordlow Jul 20, 2022
14e2e07
Qualify most foreach elements as const
nordlow Jul 22, 2022
4041ad1
Remove default init of start and end indexes for now
nordlow Jul 22, 2022
7a00e54
Convert @safe: to individual @safe-qualifications of (member) functions
nordlow Jul 25, 2022
7f34132
Avoid -dip1000 compiler error
nordlow Jul 25, 2022
a61facb
Prefix references to ru and read() with this. in Row(T).this
nordlow Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ xlsxreader-test-*
*.o
*.obj
*.lst
libxlsxreader.a
dub.selections.json
2 changes: 1 addition & 1 deletion dub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"copyright": "Copyright © 2019, Robert burner Schadek",
"dependencies": {
"dxml": "~>0.4.0"
"dxml": "~>0.4.0"
},
"description": "A very simple xlsx reader",
"license": "LGPL3",
Expand Down
Loading