Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for libc++, the LLVM C++ Standard Library. #36

Closed
wants to merge 1 commit into from
Closed

Add support for libc++, the LLVM C++ Standard Library. #36

wants to merge 1 commit into from

Conversation

matt-langston
Copy link

This PR adds support for the LLVM C++ Standard Library reported in #17. My company is using this successfully with the CrystaX NDK (required for boost) for our Android builds. Use it like this:

cmake -DCMAKE_TOOLCHAIN_FILE=android.toolchain.cmake \
-DANDROID_NDK=<ndk_path> \
-DCMAKE_BUILD_TYPE=Release \
-DANDROID_ABI="armeabi-v7a" \
-DANDROID_TOOLCHAIN_NAME=arm-linux-androideabi-clang3.5 \
-DANDROID_STL=libc++_shared \
<source_path>
cmake --build .

You can also replace -DANDROID_STL=libc++_shared with -DANDROID_STL=libc++_static.

I suggest that this PR supersede PR #33.

@@ -154,6 +154,10 @@
# Implies -frtti -fno-exceptions.
# Available for NDK r7b and newer.
# Silently degrades to gnustl_static if not available.
# libc++_static -> Use the LLVM C++ Standard Library as a static library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is confusing to use other options, than the Application.mk does.

@taka-no-me
Copy link
Owner

This is quite incomplete libc++ support. And as pointed by @abergmeier the naming should be consistent with NDK. So I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants