Save artifacts only once #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochaplashkin
force-pushed
the
fix-save-artifacts
branch
2 times, most recently
from
ae9f463
to
0bad71e
Compare
ochaplashkin
force-pushed
the
fix-save-artifacts
branch
from
0bad71e
to
c6ad320
Compare
ylobankov
reviewed
Oct 6, 2023
Since commit [1] the `Server:save_artifacts()` function was called more
than once. Due to this fact we could overwrite already saved artifacts.
Added a flag that will ensure that the saving will be executed only
once.
There was also a problem when copying artifacts was not performed but
the path to the artifacts was formed as a directory with artifacts:
artifacts:
server -> /tmp/t/artifacts/server-XXX
And if we tried to look at these artifacts, we could see this:
$ ls -la /tmp/t/artifacts/server-XXX
ls: cannot access '/tmp/t/artifacts/server-XXX': No such file or
directory
To show explicitly that the saving failed with an error, the following
string will now be written to the artifacts:
artifacts:
server -> Failed to copy artifacts for server (alias: server-XXX
workdir: /tmp/t/artifacts/server-XXX)
[1] tarantool/luatest@251b35f
Part of tarantool#304
ochaplashkin
force-pushed
the
fix-save-artifacts
branch
from
c6ad320
to
90d9ae8
Compare
ylobankov
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 1 the
Server:save_artifacts()function was called more than once. Due to this fact we could overwrite already saved artifacts. Added a flag that will ensure that the saving will be executed only once.There was also a problem when copying artifacts was not performed but the path to the artifacts was formed as a directory with artifacts:
And if we tried to look at these artifacts, we could see this:
To show explicitly that the saving failed with an error, the following
string will now be written to the artifacts:
Footnotes
https://github.com/tarantool/luatest/commit/251b35f ↩