Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save artifacts only once #330

Merged
merged 1 commit into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. Save artifacts only once

    Since commit [1] the `Server:save_artifacts()` function was called more
    than once. Due to this fact we could overwrite already saved artifacts.
    Added a flag that will ensure that the saving will be executed only
    once.
    
    There was also a problem when copying artifacts was not performed but
    the path to the artifacts was formed as a directory with artifacts:
    
        artifacts:
            server -> /tmp/t/artifacts/server-XXX
    
    And if we tried to look at these artifacts, we could see this:
    
        $ ls -la /tmp/t/artifacts/server-XXX
        ls: cannot access '/tmp/t/artifacts/server-XXX': No such file or
        directory
    
    To show explicitly that the saving failed with an error, the following
    string will now be written to the artifacts:
    
        artifacts:
            server -> Failed to copy artifacts for server (alias: server-XXX
            workdir: /tmp/t/artifacts/server-XXX)
    
    [1] tarantool/luatest@251b35f
    
    Part of tarantool#304
    Oleg Chaplashkin committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    90d9ae8 View commit details
    Browse the repository at this point in the history