Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add navigate method #7235

Merged
merged 1 commit into from
Jun 20, 2023
Merged

feat: add navigate method #7235

merged 1 commit into from
Jun 20, 2023

Conversation

jhutchins
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@jhutchins jhutchins requested a review from a team as a code owner June 17, 2023 13:22
@jhutchins jhutchins force-pushed the feat/add-navigate-method branch 5 times, most recently from 4b99b2f to 7e9b37c Compare June 17, 2023 15:36
@lucasfernog
Copy link
Member

I think we can target this for the 1.x branch instead so it lands on v1.5.

lucasfernog
lucasfernog requested changes Jun 17, 2023
View reviewed changes
core/tauri/src/window.rs Outdated Show resolved Hide resolved
@wusyong wusyong added the status: needs review A maintainer must review this code label Jun 20, 2023
@lucasfernog
Copy link
Member

Perfect!

@lucasfernog lucasfernog merged commit 2a000e1 into tauri-apps:dev Jun 20, 2023
18 checks passed
@kanatapple
Copy link
Contributor

@lucasfernog
Will this feature ship in v1.5?
If so, when will v1.5 be released?

@jhutchins jhutchins mentioned this pull request May 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
status: needs review A maintainer must review this code
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhutchins @lucasfernog @kanatapple @wusyong