Resolver 1.x

[martinfrances107]

This PR resolves a warning seen while running cargo update

warning: some crates are on edition 2021 which defaults to resolver = "2", but virtual workspaces default to resolver = "1"
note: to keep the current resolver, specify workspace.resolver = "1" in the workspace root's manifest
note: to use the edition 2021 resolver, specify workspace.resolver = "2" in the workspace root's manifest

[amrbashir]

The commit is still not signed 😅

[martinfrances107]

@amrbashir sorry to give you grief .. It seems I am all fingers and thumbs ... when contributing to a project new to me.

when I run

git log --show-signature

-- it now looks ok

commit 838de10 (HEAD -> resolver_1px, me/resolver_1px)
Good "git" signature for [email protected] with ED25519 key SHA256:29wbwo9YfOgSImgSxJ0uwO0JTFnz6ZaiF8YOC6wamhc
Author: martinfrances107 [email protected]
Date: Mon Sep 4 15:19:42 2023 +0100

chore: resolves a warning seen while running cargo update

warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest

[amrbashir]

The commit still shows as unverified

maybe you didn't add the signature in your account settings on github?

[martinfrances107]

That is a ssh key I have had posted on the site for more than 5 years

Looking to see what is different rather than just plain wrong...I am signing with SSH where as every other commit to the code base is signed with a GPG key

I see that GPG is better than ssh in that it can be revoked

So I am going to setup a GPG key one sec..

Generating a GPG signing key is more involved than generating an SSH key, but GPG has features that SSH does not. A GPG key can expire or be revoked when no longer used. GitHub shows commits that were signed with such a key as "Verified" unless the key was marked as compromised. SSH keys don't have this capability.

[FabianLars]

I also use my ssh key on one of my machines for commit signing. One weird gatcha is that you have to add the key to github twice, as an authentication key and as a signing key. Being able to use it as a signing key is a relatively new feature so if you didn't update it for 5 years github probably doesn't recognize it as a signing key yet.

[martinfrances107]

@FabianLars thank you very much for the advice ... in the end I created a new PR which I can see has the verified badge. ( #7753)

I dropped the SSH approach and followed the GPG key tutorials