Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolves a warning seen while running cargo update #7753

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

martinfrances107
Copy link
Contributor

This my third attempt to generate a PR with a "verified" signature.
Sorry for the noise, and thanks for all the technical support/advice
#7747
#7743

I can see the "Verified" badge on this PR. Anyway back to the reason for the PR

...

This PR resolves a warning seen while running cargo update

warning: some crates are on edition 2021 which defaults to resolver = "2", but virtual workspaces default to resolver = "1"
note: to keep the current resolver, specify workspace.resolver = "1" in the workspace root's manifest
note: to use the edition 2021 resolver, specify workspace.resolver = "2" in the workspace root's manifest

warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
@martinfrances107 martinfrances107 requested a review from a team as a code owner September 5, 2023 09:44
@martinfrances107 martinfrances107 mentioned this pull request Sep 5, 2023
@FabianLars
Copy link
Member

Now it's verified, thanks :D

about the change itself, i'm not sure what the others think but imo we should go for resolver 2 nowadays 🤔

@martinfrances107
Copy link
Contributor Author

Now using resolver 2

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@amrbashir amrbashir merged commit 5087890 into tauri-apps:1.x Sep 5, 2023
3 checks passed
@martinfrances107 martinfrances107 deleted the resolve_1_x_pgp branch September 5, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants