Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): allow custom protocol handler to resolve async #7754

Merged
merged 30 commits into from
Sep 6, 2023
Merged

refactor(core): allow custom protocol handler to resolve async #7754

merged 30 commits into from
Sep 6, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

lucasfernog and others added 19 commits September 5, 2023 16:50
@lucasfernog lucasfernog marked this pull request as ready for review September 6, 2023 16:11
@lucasfernog lucasfernog requested a review from a team as a code owner September 6, 2023 16:11
amrbashir
amrbashir requested changes Sep 6, 2023
View reviewed changes
.changes/custom-protocol-response-refactor.md Outdated Show resolved Hide resolved
.changes/http-drop-export.md Outdated Show resolved Hide resolved
core/tauri/src/ipc/channel.rs Show resolved Hide resolved
core/tauri/src/manager.rs Outdated Show resolved Hide resolved
core/tauri/src/manager.rs Outdated Show resolved Hide resolved
core/tauri/src/menu/icon.rs Outdated Show resolved Hide resolved
core/tauri/src/window.rs Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 0d63732 into dev Sep 6, 2023
24 checks passed
@lucasfernog lucasfernog deleted the refactor/custom-protocol-response branch September 6, 2023 18:53
This was referenced Sep 9, 2023
Closed
Closed
@amrbashir amrbashir mentioned this pull request Sep 13, 2023
Closed
14 tasks
@lucasfernog lucasfernog mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasfernog @amrbashir