feat(webgpu-rendering-context): import webgpu renderer #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and creates a renderer
Lutra-Fs
requested changes
Sep 12, 2023
|
they are already in the three package, and import will work with current configuration. |
this commits fix that vite is complaining about top-level await used in threejs. it is ok to bump the version since our support target is 2 most recent Chromium/Firefox/Safari version Signed-off-by: Bill ZHANG <[email protected]>
Lutra-Fs
requested changes
Sep 12, 2023
src/components/Simulation.tsx
Outdated
| @@ -59,6 +63,15 @@ function DiffusionPlane( | |||
| props: ThreeElements['mesh'] & Renderable, | |||
| ): React.ReactElement { | |||
| // INITIALISATION | |||
|
|
|||
| // WebGPU capability test | |||
| if ( WebGPU.isAvailable() === true ) { | |||
There was a problem hiding this comment.
CFlowSim\src\components\Simulation.tsx
68:8 error Unsafe call of an `any` typed value @typescript-eslint/no-unsafe-call
69:11 error Unsafe assignment of an `any` value @typescript-eslint/no-unsafe-assignment
line returns these errors in npm run lint
There was a problem hiding this comment.
Also pls make sure that you have configured prettier as the formatter.
Understood. pls resolve format and linting error to get it merged |
kyubxy
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #74