Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IComparable in Vector2 and unit tests for it #47

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Hypercube.Mathematics/Vectors/Vector2.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
namespace Hypercube.Mathematics.Vectors;

[PublicAPI, StructLayout(LayoutKind.Sequential)]
public readonly partial struct Vector2 : IEquatable<Vector2>
public readonly partial struct Vector2 : IEquatable<Vector2>, IComparable<Vector2>
{
public static readonly Vector2 NaN = new(float.NaN, float.NaN);
public static readonly Vector2 Zero = new(0, 0);
Expand Down Expand Up @@ -279,4 +279,16 @@ public static float Cross(Vector2 a, Vector2 b)
{
return a.X * b.Y - a.Y * b.X;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public int CompareTo(Vector2 other)
{
return LengthSquared.CompareTo(other.LengthSquared);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public int CompareTo(Vector2 other, Func<Vector2, double> selector)
{
return selector(this).CompareTo(selector(other));
}
}
96 changes: 96 additions & 0 deletions Hypercube.UnitTests/Math/CompareToTest.cs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На будущее, я пока не написал гайдлайны, если есть возможность лучше использовать var, вместо прямого указание типа, хоть это и не сходится с нотацией от Microsoft

Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
using System;
using Hypercube.Math.Vectors;

Check failure on line 2 in Hypercube.UnitTests/Math/CompareToTest.cs

View workflow job for this annotation

GitHub Actions / Windows Build

The type or namespace name 'Math' does not exist in the namespace 'Hypercube' (are you missing an assembly reference?)
using NUnit.Framework;

namespace Hypercube.UnitTests.Math;

[TestFixture]
public sealed class CompareToTest
{
[Test]
public void CompareTo_LengthComparison_ReturnsExpectedResult()
{
// Arrange
var vector1 = new Vector2(3, 4); // Length = 5
var vector2 = new Vector2(6, 8); // Length = 10

// Act
var result = vector1.CompareTo(vector2);

// Assert
Assert.Less(result, 0);
}

[Test]
public void CompareTo_XComponentComparison_ReturnsExpectedResult()
{
// Arrange
var vector1 = new Vector2(3, 4);
var vector2 = new Vector2(6, 4);

// Act
var result = vector1.CompareTo(vector2, v => v.X);

// Assert
Assert.Less(result, 0); // Expecting vector1 to be "less than" vector2 based on X component
}

[Test]
public void CompareTo_YComponentComparison_ReturnsExpectedResult()
{
// Arrange
var vector1 = new Vector2(3, 4);
var vector2 = new Vector2(3, 2);

// Act
var result = vector1.CompareTo(vector2, v => v.Y);

// Assert
Assert.Greater(result, 0); // Expecting vector1 to be "greater than" vector2 based on Y component
}

[Test]
public void CompareTo_AngleComparison_ReturnsExpectedResult()
{
// Arrange
var vector1 = new Vector2(0, 1); // Angle = π/2 (90 degrees)
var vector2 = new Vector2(1, 0); // Angle = 0 degrees

// Act
var result = vector1.CompareTo(vector2, v => v.Angle);

// Assert
Assert.Greater(result, 0); // Expecting vector1 to be "greater than" vector2 based on Angle
}

[Test]
public void CompareTo_SameVectors_ReturnsZero()
{
// Arrange
var vector1 = new Vector2(3, 4);
var vector2 = new Vector2(3, 4);

// Act & Assert
Assert.AreEqual(0, vector1.CompareTo(vector2));
Assert.AreEqual(0, vector1.CompareTo(vector2, v => v.X));
Assert.AreEqual(0, vector1.CompareTo(vector2, v => v.Y));
Assert.AreEqual(0, vector1.CompareTo(vector2, v => v.Angle));
}

[Test]
public void CompareTo_DifferentComparisons_ReturnDifferentResults()
{
// Arrange
var vector1 = new Vector2(1, 2);
var vector2 = new Vector2(2, 1);

// Act
var lengthComparison = vector1.CompareTo(vector2);
var xComponentComparison = vector1.CompareTo(vector2, v => v.X);
var yComponentComparison = vector1.CompareTo(vector2, v => v.Y);

// Assert
Assert.AreNotEqual(lengthComparison, xComponentComparison);
Assert.AreNotEqual(xComponentComparison, yComponentComparison);
}
}
Loading