Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check both stdout and stderr in package manager tests #3227

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

psss
Copy link
Collaborator

@psss psss commented Sep 19, 2024

We don't care that much where dnf puts the info about which packages were installed. Plus in different dnf versions the output goes into different output streams. See also:

Pull Request Checklist

  • extend the test coverage

@psss psss added test coverage Improvements or additions to test coverage of tmt itself area | package managers Changes related to implementations of package managers ci | full test Pull request is ready for the full test execution labels Sep 19, 2024
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psss psss force-pushed the package-managers-test-output branch 3 times, most recently from 5c1427f to 25ec7b9 Compare September 20, 2024 10:19
We don't care that much where `dnf` puts the info about which
packages were installed. Plus in different `dnf` versions the
output goes into different output streams. See also:

* rpm-software-management/dnf5#1641
@psss psss force-pushed the package-managers-test-output branch from 25ec7b9 to d06f612 Compare September 20, 2024 10:21
@psss psss added this to the 1.37 milestone Sep 20, 2024
@psss psss merged commit 94f2573 into main Sep 20, 2024
23 checks passed
@psss psss deleted the package-managers-test-output branch September 20, 2024 12:53
@psss psss self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | package managers Changes related to implementations of package managers ci | full test Pull request is ready for the full test execution test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants