Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure Test Code Coverage for Tekton Results repo #1591

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Measure Test Code Coverage for Tekton Results repo #1591

merged 1 commit into from
Sep 14, 2023

Conversation

xinredhat
Copy link
Contributor

@xinredhat xinredhat commented Sep 12, 2023 •
edited
Loading

Changes

Add test code coverage for Tekton Results, this is the ticket https://issues.redhat.com/browse/PLNSRVCE-1106

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 12, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xinredhat / name: Xin Jiang (b79d96f)

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2023
@tekton-robot
Copy link
Contributor

Hi @xinredhat. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2023
khrm
khrm reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2023
@khrm
Copy link
Contributor

khrm commented Sep 12, 2023

@xinredhat Please sign the cla.

khrm
khrm reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 12, 2023
@xinredhat
Copy link
Contributor Author

@khrm I signed the cla.

khrm
khrm reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @dibyom @afrittoli

/approve

@xinredhat
Copy link
Contributor Author

@dibyom @afrittoli could you help review this PR?

@afrittoli
Copy link
Member

Add test code coverage for Tekton Results, this is the ticket https://issues.redhat.com/browse/PLNSRVCE-1106

Thank you for your contribution @xinredhat and welcome to the community!

A small suggestion, Tekton uses public GitHub issues to track issues - I would recommend not to link issues in other issue-tracking systems unless they're publicly accessible (I cannot access the link you shared).

afrittoli
afrittoli reviewed Sep 14, 2023
View reviewed changes
prow/config.yaml
clone_uri: "https://github.com/tektoncd/results.git"
spec:
containers:
- image: gcr.io/tekton-releases/dogfooding/coverage:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably stop using latest in future, but all repos do for coverage, so this is fine for now.

Copy link
Contributor

@khrm khrm Sep 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue here: #1593 to track this.

afrittoli
afrittoli reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@afrittoli
Copy link
Member

Another suggestion, could you please sign your commits in future?

@xinredhat
Copy link
Contributor Author

Another suggestion, could you please sign your commits in future?

sure. thank you for the suggestion

dibyom
dibyom reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@tekton-robot tekton-robot merged commit 74e5d53 into tektoncd:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@afrittoli afrittoli afrittoli left review comments

@khrm khrm khrm left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@afrittoli afrittoli

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xinredhat @tekton-robot @khrm @afrittoli @dibyom