Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prow setup for feature flag tests #1803

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

JeromeJu
Copy link
Member

Changes

This commit adds the prow setup for feature flag tests.

/kind misc
fixes: #1629

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

This commit adds the prow setup for feature flag tests.

/kind misc
fixes: tektoncd#1629
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 12, 2024
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2024
@JeromeJu
Copy link
Member Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Contributor

@JeromeJu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

Use /test all to run the following jobs that were automatically triggered:

  • pull-tekton-plumbing-check-testgrid-config

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member

dibyom commented Feb 12, 2024

/test plumbing-unit-tests

@tekton-robot
Copy link
Contributor

@dibyom: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

Use /test all to run the following jobs that were automatically triggered:

  • pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @vdemeester @afrittoli - adding a new prow job. they might have an impact on CI/infra costs

prow/config.yaml Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

/test plumbing-unit-tests

@tekton-robot
Copy link
Contributor

@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

Use /test all to run the following jobs that were automatically triggered:

  • pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu
Copy link
Member Author

/test plumbing-unit-tests

This unit test seems pretty broken 🤔 #1804

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@tekton-robot tekton-robot merged commit 7f0f39f into tektoncd:main Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plumbing Setup for Additional CI tests for Per-feature Flag Testing Matrix
4 participants