chore: upgrade phpstan to v2 #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackshadev
force-pushed
the
phpstan-v2
branch
from
7101d86 to
7276356
Compare
innocenzi
changed the title
aidan-casey
reviewed
Dec 7, 2024
There was a problem hiding this comment.
@blackshadev overall looks good, thank you! Just a few comments.
|
Nice! |
blackshadev
force-pushed
the
phpstan-v2
branch
from
7276356 to
387e9d3
Compare
|
Pipeline fixed, newly introduced code from main had a new error in it, adding it to the baseline for now. |
|
Let's go! |
|
FYI @blackshadev @aidan-casey @brendt |
|
Thank you, @carlosas! Appreciate your continued work on the project! |
Thanks, created an MR to re-add it #873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why not wait?
Well , as it stands, phpstan doesn't allot for property hooks, I tried a property hook in an interface and phpstan paniced to the point it became unusable. In my opinion, I rather have php 8.4 features, than the features added by phpat, which can be re-added when phpat does provide phpstan 2.0 support.
Why the baseline
I rather introduce phpstan 2.0 early and fix the issues from the baseline later, the alternative is my trying to clean up while others keep on piling new issues without them even knowing they did it (because phpstan 2 has become more strict)