Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add back php architecture tests #873

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore: add back php architecture tests #873

merged 1 commit into from
Jan 9, 2025

Conversation

blackshadev
Copy link
Contributor

@blackshadev blackshadev commented Dec 27, 2024 •
edited
Loading

Why

phpat supports phpstan 2

What

  • Re-add phpat based on the deletion in chore: upgrade phpstan to v2 #821
  • I needed to change one extra file: src/Tempest/Generation/src/Exceptions/FileGenerationFailedException.php, it was newly introduced after the removal of phpat and it did not adhere to our final rules. I checked the catch statements where the extended clauses where used and this change shouldn't affect it.

@blackshadev blackshadev mentioned this pull request Dec 27, 2024
Merged
@innocenzi innocenzi changed the title feat: readd php architecture tests chore: add back php architecture tests Dec 27, 2024
@brendt brendt merged commit 3279ac3 into tempestphp:main Jan 9, 2025
66 checks passed
@brendt
Copy link
Member

brendt commented Jan 9, 2025

Nice! Appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackshadev @brendt