PHP SDK integration

[roxblnfk]

What was changed

Added runner preparation:

• configuring SDK version
• downloading PHP vendor packages
• downloading RoadRunner
• do it in a separated directory

Added runner that runs RoadRunner and starts PHP features in a single run.

Implemented features:

• activity 3 / 5
• build_id_versioning 0 / 6 (not supported)
  • [Feature Request] Allow to register checksum with the worker sdk-php#311
• child_workflow 3 / 13
  • Child Workflow doesn't inherit parent's Task Queue sdk-php#451
• client 0 / 2
• continue_as_new 1 / 1
  • ContinueAsNew options dto doesn't inherit Workflow's Task Queue sdk-php#453
• data_converter 7 / 7
  • Add Binary Protobuf Converter into default set sdk-php#455
  • Encode Failures using EncodedAttributes sdk-php#454
• eager_activity 0 / 1 (waiting SDK feature)
  • [Feature Request] Add new options into WorkerOptions sdk-php#456
• eager_workflow 1 / 1
• local_activity 0 / 15 (all cases are empty)
• query 5 / 5
• reset 0 / 1 (not required)
• schedule 4 / 5 (our cron doesn't support seconds. Should it support seconds?)
• search_attributes 0 / 2 (all cases are empty)
• signal 6 / 7
  • Signal from signal-with-start must be processed before Workflow Handler initialization sdk-php#457
• telemetry 0 / 1 (OTEL package is not released yet)
• timer 0 / 0
• tracing 0 / 0
• update 11 / 11
  • [Feature Request] Expose WorkflowStub::getUpdateHandle() method sdk-php#458
  • Updates: retryable exceptions sdk-php#463

Checklist

• Closes [Feature Request] PHP harness #103
• CI
  • Register docker image there https://github.com/temporalio/docker-builds/blob/main/.github/workflows/features-integration.yml
    • Add PHP docker image building #541
    • Publish PHP in the Dockerhub #546
    • Wait for merging this PR
    • CI: Feature Integration: add PHP docker-builds#253

How to run

go build -o temporal-features
./temporal-features run --lang php

Windows:

go build -o temporal-features.exe
./temporal-features.exe run --lang php

[roxblnfk]

About this option:

• eager_activity 0 / 1 (waiting SDK feature)
  [Feature Request] Add new options into WorkerOptions sdk-php#456

Adding this test requires adjustments to the framework because RR needs to be restarted with special worker settings.
I'm not sure it's worth spending time on it right now.

[roxblnfk]

Ready for review.
You don't need to spend effort reviewing PHP files.
For the most part, they are the same tests that are also run in the PHP-SDK.

[Sushisource]

Awesome. Having this is super valuable.

[roxblnfk]

Looks like system.enableEagerWorkflowStart is not true now. That's why the EagerWorkflow test is failing.

Might be related with #543

[roxblnfk]

BTW is it okay that I'm getting TRUE in the eagerWorkflowStart field of a ServerCapabilities response while the server is started with the option system.enableEagerWorkflowStart=false?

[Sushisource]

Looks like system.enableEagerWorkflowStart is not true now. That's why the EagerWorkflow test is failing.

Might be related with #543

Ah, interesting... yeah could be.

BTW is it okay that I'm getting TRUE in the eagerWorkflowStart field of a ServerCapabilities response while the server is started with the option system.enableEagerWorkflowStart=false?

Hmm... I think it might be OK even if it's kinda weird. I think the semantics of the API are merely that it can support it at that version, not that it's currently enabled... which does seem a little silly.

[roxblnfk]

@Sushisource now it works 👍

It may be necessary to add dynamicconfig to the Dockerfiles of other SDKs in the future, as done in the PHP Dockerfile. At least for now, the tests there are not failing. 🙂