Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build a Temporal Application from scratch in TypeScript v2 #345

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Build a Temporal Application from scratch in TypeScript v2 #345

merged 10 commits into from
Dec 18, 2024

Conversation

napcs
Copy link
Contributor

@napcs napcs commented Dec 12, 2024

Complete rewrite of the Hello World tutorial in TypeScript.

  • Code is not snipsync'd yet but will be upon publication.

@napcs napcs requested a review from a team as a code owner December 12, 2024 00:12
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 7:48pm

napcs
napcs commented Dec 12, 2024
View reviewed changes
Copy link
Contributor Author

@napcs napcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated Angela's comments and feedback

@napcs @brianmacdonald-temporal @angelazhou32
Apply suggestions from Angela's review
5e2b929 
Co-authored-by: Brian MacDonald <[email protected]>
Co-authored-by: angelazhou32 <[email protected]>
brianmacdonald-temporal
brianmacdonald-temporal approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good tutorial! Just about everything is clear and well-explained. I caught a couple of items you might want to check on, and the rest is just wordsmithing.

docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
docs/getting_started/typescript/hello_world_in_typescript/index.md Outdated Show resolved Hide resolved
@napcs napcs mentioned this pull request Dec 17, 2024
Merged
@napcs napcs merged commit 9f066c6 into main Dec 18, 2024
4 checks passed
@napcs napcs deleted the build-first-app-ts-v2 branch December 18, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelazhou32 angelazhou32 angelazhou32 left review comments

@brianmacdonald-temporal brianmacdonald-temporal brianmacdonald-temporal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@napcs @angelazhou32 @brianmacdonald-temporal