Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Ubuntu Noble #1006

Merged
merged 5 commits into from
Jun 23, 2024
Merged

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented May 30, 2024

No description provided.

@marip8
Copy link
Contributor Author

marip8 commented May 30, 2024

I don't really have time at the moment to see this PR through, but we ought to start supporting builds on noble since we are merging other PRs that address build compatibility on that platform

@rjoomen
Copy link
Contributor

rjoomen commented Jun 19, 2024

That's strange, with colcon-action@v7 both Jammy and Noble say:

E: Unable to locate package python3-vcstool
E: Unable to locate package python3-colcon-common-extensions
E: Unable to locate package python3-rosdep

But I've checked, on my Jammy and Noble installations these packages are available.

Update: they are from the ROS package repo.

@rjoomen
Copy link
Contributor

rjoomen commented Jun 19, 2024

  • CI for Ubuntu/noble works. The build fails, as expected, on Noble-related issues, but not on the CI setup itself (see e.g. here).
  • CI for Docker/noble needs fixes similar to colcon-action, could you look into that, @marip8?

Once we have this PR merged I'll start updating the CIs of the other projects as well.

@marip8
Copy link
Contributor Author

marip8 commented Jun 19, 2024

CI for Docker/noble needs tesseract-robotics/colcon-action#11, could you look into that, @marip8?

Will do

@rjoomen
Copy link
Contributor

rjoomen commented Jun 23, 2024

This can be merged now.

@Levi-Armstrong Levi-Armstrong merged commit efcea85 into tesseract-robotics:master Jun 23, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants