Fix use of compound mesh in FCL #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
force-pushed
the
bugfix/fcl-compound-mesh
branch
from
ec9ef9d to
5cba2a9
Compare
rjoomen
force-pushed
the
bugfix/fcl-compound-mesh
branch
from
5cba2a9 to
211da43
Compare
Levi-Armstrong
force-pushed
the
bugfix/fcl-compound-mesh
branch
2 times, most recently
from
8c5cae1 to
79d5edb
Compare
|
@rjoomen Hey, I did not realize you had pushed changes and I force pushed after I noticed my local clang tidy build failed. What changes did you make? |
|
No changes, I just rebased on master using Github. |
|
I'll look into this tomorrow. |
Levi-Armstrong
force-pushed
the
bugfix/fcl-compound-mesh
branch
from
79d5edb to
6d16ec5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
- Coverage 89.40% 89.40% -0.01%
==========================================
Files 288 288
Lines 16304 16303 -1
==========================================
- Hits 14577 14576 -1
Misses 1727 1727 |
Levi-Armstrong
force-pushed
the
bugfix/fcl-compound-mesh
branch
from
6d16ec5 to
00a03ba
Compare
Levi-Armstrong
force-pushed
the
bugfix/fcl-compound-mesh
branch
from
00a03ba to
1b035c7
Compare
|
Seems like a better solution, and it works, thanks. I added a small simplification. |
Levi-Armstrong
merged commit 6757445
into
tesseract-robotics:master
13 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1053
@rjoomen After looking through the code I went a slight different route to solve another issue with get the correct shape index. Do you mind testing this?