Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use applyContactManagerConfig instead of manually setting #282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpowelson
Copy link
Contributor

Switch to using applyContactManagerConfig rather than doing it manually (and partially)

@mpowelson
Copy link
Contributor Author

This is failing because it doesn't handle the collision buffer. I'll have to look more into what to do here. There is also interplay with the CollisionCoeffData

@Levi-Armstrong
Copy link
Contributor

I think to apply the buffer it should probably internally create a new margin data by looping over the provided one and increasing the margin buffer. Though we would need to make sure that pairs with custom distance other than the default are handled correctly with regards to the buffer.

@Levi-Armstrong
Copy link
Contributor

@mpowelson what are the next steps on this PR?

@mpowelson
Copy link
Contributor Author

@mpowelson what are the next steps on this PR?

I'm not sure. We'll have to figure out how we want to handle the CollisionCoeffData and the Collision margin data. Maybe we should add an apply method to the config. Otherwise, I'm not sure how to make the contact manager apply derived configs like this correctly.

@drchrislewis
Copy link

@Levi-Armstrong https://m.youtube.com/watch?v=v6MhPl2ICsc don't have your current email. Saw this video, seems like control of walking is a real time nonlinear constrained optimization problem using distance field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants