Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display author in list of commits #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hariom147
Copy link

Hi,
first of all thanks for this plugin. This is only the second time I'm contributing a PR, so please excuse any mistakes 🙂

I added the author info for my own purposes and thought in might benefit others as well.
I also tried using your coding-patterns...

This is what it looks like:
Screenshot 2024-08-24 at 18 26 49

@thathoff
Copy link
Owner

Thank you @hariom147, it looks good (especially for your second PR)! I actually had the same idea and have already included it in a more elaborate extension of the panel view: https://github.com/thathoff/kirby-git-content/blob/commit-by-pages/js/components/GitContent.vue#L113

But your PR is quite small and my changes will take some time to finish, so I'm looking forward to testing and merging this!

One wish: I think we can safely add this feature without an option, as I cannot imagine a case where this information should be hidden. This removes some of the complexity of your changes (even if they are small) and does not introduce a new option. Would you mind changing the feature so that it does not require an option?

@hariom147
Copy link
Author

hariom147 commented Aug 28, 2024

Thanks for the Kind words - with the Vue template part I had some help using Cursor 🤠

I am traveling at the moment and will update the PR next weekend.

Looking forward to the improvements you're working on...

@hariom147
Copy link
Author

hariom147 commented Aug 28, 2024

Would you mind changing the feature so that it does not require an option?

I just found some time to make the changes and force-pushed to overwrite the last commit. I hope I did it the right way...

@hariom147 hariom147 changed the title optionally display author in list of commits display author in list of commits Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants