Increase static analysis #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Coverage is ignored because it's tested at a static analysis level
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage ? 92.13%
Complexity ? 33
=========================================
Files ? 7
Lines ? 89
Branches ? 0
=========================================
Hits ? 82
Misses ? 7
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dbrekelmans
approved these changes
Nov 25, 2024
|
@dbrekelmans thanks for the merge. CI is failing in the main branch due to Codecov not accepting the upload. You should configure it on your side to either accept unauthenticated uploads or by adding a token here on GHA. Docs for the token: https://docs.codecov.com/docs/adding-the-codecov-token |
|
Pinging @moufmouf in case he's the one with the right access to Codecov... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #36, to have proper CI checks.
With this, I intend to cover tests with PHPStan, so that the checks are stronger; also, I will do some fixing on how the tests work, because currently they need some maintenance.