add JS plugin test workflow #47
Conversation
evgeni
force-pushed
the
jstests
branch
7 times, most recently
from
843a0c7 to
fa9218a
Compare
|
The failures are legit and fixed in Katello/katello#10929 and theforeman/foreman#10095 |
evgeni
force-pushed
the
jstests
branch
3 times, most recently
from
a9e2371 to
93caebe
Compare
|
cc @dosas you might be interested :) |
|
@evgeni Thanks, very nice! |
| exclude: ${{ inputs.matrix_exclude }} | ||
|
|
||
| test: | ||
| name: "Foreman ${{ inputs.foreman_version }} Ruby ${{ matrix.ruby }} and Node ${{ matrix.node }}" |
There was a problem hiding this comment.
Foreman's postinstall script calls script/npm_install_plugins.js
https://github.com/theforeman/foreman/blob/4abf925fbd72264e8c316d720c03c1dd75688507/package.json#L19
And that, via script/plugin_webpack_directories.js needs Ruby.
There was a problem hiding this comment.
Mind you, we just ensure Ruby is there, we do not install any gems or anything, so that step is rather quick.
(also, you only need foreman to be even there for some plugins that share code with Foreman via find-foreman: https://github.com/Katello/katello/blob/master/webpack/.eslintrc.js, https://github.com/theforeman/foreman_openscap/blob/02d91220a206b6c121f6938a826eb9b4598af2f3/jest.config.js#L4)
There was a problem hiding this comment.
We could also skip installing a specific Ruby, given that GHA images come with Ruby pre-installed, but it felt wrong to me as that could lead to a version of Ruby that is unsupported by our stack.
|
🍏 |
|
Documenting this in README would be nice. |
|
#48 adds docs |
Fixes: #42