Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nodejs-babel-preset-env to 7.9.5 #11257

Open
wants to merge 1 commit into
base: rpm/develop
Choose a base branch
from

Conversation

MariaAga
Copy link
Member

babel-preset-env was an old version, i'm moving it from foreman builder to foreman theforeman/foreman#10319
For now babel-preset-env v7 does exist in packaging but under foreman builder

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this works. Looking at https://www.npmjs.com/package/@babel/preset-env/v/7.9.5?activeTab=dependencies it has a lot of dependencies and I'm afraid we need to vendor those.

@MariaAga
Copy link
Member Author

we need to vendor those.

What does that mean & how?

@MariaAga
Copy link
Member Author

Also will need to update to 7.25, if its ok to update in the foreman pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants