-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37819 - Remove @theforeman/builder usage #10319
base: develop
Are you sure you want to change the base?
Conversation
da895e1
to
ca27926
Compare
config/webpack.config.js
Outdated
@@ -97,7 +97,7 @@ const commonConfig = function() { | |||
exclude: /node_modules(?!\/(@novnc|unidiff))/, | |||
loader: 'babel-loader', | |||
options: { | |||
presets: [require.resolve('@theforeman/builder/babel')], | |||
presets: [require.resolve('../webpack/babel')], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other places we always use __dirname
. I'd prefer it if we were consistent and didn't rely on the current working directory too much. Perhaps we need a new const project_root = path.join(__dirname, '..')
that can then be used everywhere.
ca27926
to
3d299f7
Compare
Need to fix the imports yeah, thanks! |
3d299f7
to
370d14e
Compare
370d14e
to
d65c93a
Compare
@theforeman/packaging I'm assuming theforeman/foreman-packaging#11257 will make rpm-build happy? |
d65c93a
to
979acb9
Compare
979acb9
to
fa8205c
Compare
Moving it into foreman from foreman-js.
I saw it being used in some plugins and I think it can be removed from them, if they run
npm test
and webpack compilation goes without errors for them (for example: REX).Other plugins can stop using builder as well and import from core directly, for example, in Katello:
Also updated babel & babal-preset-env, all the plugins that are in the babel config are already in preset-env new version so no need to move them
('@babel/plugin-proposal-class-properties'
'@babel/plugin-proposal-object-rest-spread'
'@babel/plugin-proposal-optional-chaining'
'@babel/plugin-transform-object-assign'
'@babel/plugin-syntax-dynamic-import'
'@babel/plugin-syntax-optional-chaining')