Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubygem-newt to 1.0.1 #11268

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Update rubygem-newt to 1.0.1 #11268

merged 1 commit into from
Sep 24, 2024

Conversation

stejskalleos
Copy link

@stejskalleos stejskalleos commented Sep 19, 2024 •
edited
Loading

No description provided.

@stejskalleos stejskalleos mentioned this pull request Sep 19, 2024
Merged
ekohl
ekohl reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that it doesn't show up in https://yum.theforeman.org/plugins/nightly/el9/x86_64/ because it is listed in comps and we have built it: https://copr.fedorainfracloud.org/coprs/g/theforeman/plugins-nightly-staging/package/rubygem-newt/

@evgeni any idea?

packages/plugins/rubygem-newt/rubygem-newt.spec Outdated Show resolved Hide resolved
packages/plugins/rubygem-newt/rubygem-newt.spec Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Sep 19, 2024

Oh, I just noticed: we did build it for EL8 but not for EL9.

@stejskalleos
Copy link
Author

The job is failing with:

RPM build errors:
error: File not found: /builddir/build/BUILDROOT/rubygem-newt-1.0.1-1.el9.x86_64/usr/lib64/gems/ruby/newt-1.0.1
    File not found: /builddir/build/BUILDROOT/rubygem-newt-1.0.1-1.el9.x86_64/usr/lib64/gems/ruby/newt-1.0.1
Finish: rpmbuild rubygem-newt-1.0.1-1.el9.src.rpm
Finish: build phase for rubygem-newt-1.0.1-1.el9.src.rpm

But why it can't find the rpm or what does it mean I really don't know. @theforeman/packaging any tips?

@evgeni
Copy link
Member

evgeni commented Sep 19, 2024

0.9.7 didn't work on Ruby3, so we never built it :)

@evgeni evgeni changed the title Regenerate spec for rubygem-newt Update rubygem-newt to 1.0.1 Sep 24, 2024
@stejskalleos
Copy link
Author

Thanks, @ekohl @evgeni. It's green now 🍏

@evgeni
Copy link
Member

evgeni commented Sep 24, 2024

One last question before I merge this: is the code in https://github.com/theforeman/foreman-discovery-image compatible with 1.0 newt?

@stejskalleos
Copy link
Author

One last question before I merge this: is the code in https://github.com/theforeman/foreman-discovery-image compatible with 1.0 newt?

I'm working on the EL9 version, and for the EL8 version, there are no plans for additional releases.

@evgeni evgeni merged commit 48a6dfe into theforeman:rpm/develop Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
RPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stejskalleos @ekohl @evgeni