Fixes #37427 - Fix some Style/ cop

app/helpers/form_helper.rb

@@ -315,8 +315,7 @@ def add_label(options, f, attr)
     if options[:label_help].present?
       label += ' '.html_safe + popover("", options[:label_help], options[:label_help_options] || {})
     end
-    label = label.present? ? label_tag(attr, label.to_s + required_mark.to_s, :class => label_size + " control-label") : ''
-    label
+    label.present? ? label_tag(attr, label.to_s + required_mark.to_s, :class => label_size + " control-label") : ''
   end
 
   def check_required(options, f, attr)

app/models/compute_resource.rb

@@ -375,8 +375,7 @@ def vm_compute_attributes(vm)
     vm_attrs = vm_attrs.reject { |k, v| k == :id }
 
     vm_attrs = set_vm_volumes_attributes(vm, vm_attrs)
-    vm_attrs = set_vm_interfaces_attributes(vm, vm_attrs)
-    vm_attrs
+    set_vm_interfaces_attributes(vm, vm_attrs)
   end
 
   def vm_ready(vm)

app/models/host/managed.rb

@@ -535,8 +535,7 @@ def apply_inherited_attributes(attributes, initialized = true)
       attributes[attribute] = value
     end
 
-    attributes = apply_facet_attributes(new_hostgroup, attributes)
-    attributes
+    apply_facet_attributes(new_hostgroup, attributes)
   end
 
   def hash_clone(value)

app/services/foreman/renderer.rb

@@ -28,7 +28,7 @@ def render_template_to_tempfile(template:, prefix:, host: nil, params: {}, varia
         file
       end
 
-      def get_source(klass: nil, template:, **args)
+      def get_source(template:, klass: nil, **args)
         klass ||= Foreman::Renderer::Source::Database
         klass.new(template)
       end

app/services/foreman/renderer/source/string.rb

@@ -2,7 +2,7 @@ module Foreman
   module Renderer
     module Source
       class String < Foreman::Renderer::Source::Base
-        def initialize(name: 'Unnamed', content:)
+        def initialize(content:, name: 'Unnamed')
           @name = name
           @content = content
         end

app/services/proxy_reference_registry.rb

@@ -44,8 +44,7 @@ def join_reference_arrays(references, other_references)
         end
         memo
       end
-      references = references.concat to_add
-      references
+      references.concat to_add
     end
 
     private

config/initializers/ldap_instrumentation.rb

@@ -1,6 +1,6 @@
-require 'foreman/ldap/ldap_subscriber.rb'
-require 'foreman/ldap/ldap_fluff_subscriber.rb'
-require 'foreman/ldap/net_ldap_subscriber.rb'
+require 'foreman/ldap/ldap_subscriber'
+require 'foreman/ldap/ldap_fluff_subscriber'
+require 'foreman/ldap/net_ldap_subscriber'
 
 # Debug logging from net-ldap and ldap_fluff events sent via ActiveSupport::Notifications
 Rails.application.config.after_initialize do