Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37427 - Fix some Style/ cop #10080

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

archanaserver
Copy link
Contributor

Fixed Style/RedundantAssignment & Style/RedundantFileExtensionInRequire cop.

Check commits for more details

@archanaserver archanaserver changed the title Fix some Style/* cop Fix some Style/ cop Mar 6, 2024
script/dynflowd Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the test failures are related. Perhaps they're solved if you rebase.

Also, please open Redmine issues.

@archanaserver archanaserver changed the title Fix some Style/ cop Fixes #37426 - Fix some Style/ cop May 9, 2024
@archanaserver archanaserver changed the title Fixes #37426 - Fix some Style/ cop Fixes #37427 - Fix some Style/ cop May 9, 2024
@archanaserver archanaserver force-pushed the style-cop-fix branch 2 times, most recently from 5eb0c44 to 10b87e3 Compare May 15, 2024 09:39
@ares
Copy link
Member

ares commented Jun 24, 2024

Needs also a rebase now.

This cop efficiently detects and fixes unnecessary variable assignments
before returning values in methods. Also improves redability of code
by reducing clutter.

https://docs.rubocop.org/rubocop/cops_style.html#styleredundantassignment
This cop identifies and recommends removing redundant '.rb' file extensions
specified in require and require_relative statements. Omitting the extension
improves code clarity and adheres to Ruby's behavior.
https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfileextensioninrequire
This cop ensures that optional keyword parameters are positioned at the
end of the parameters list. This promotes readability by following the
common convention of placing required parameters first and optional
parameters last.

https://docs.rubocop.org/rubocop/cops_style.html#stylekeywordparametersorder
@ehelms ehelms merged commit 2556ac5 into theforeman:develop Oct 17, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants