Fixes #37427 - Fix some Style/ cop #10080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
ekohl
requested changes
Mar 21, 2024
archanaserver
force-pushed
the
style-cop-fix
branch
from
c1f6fea
to
648ad57
Compare
archanaserver
force-pushed
the
style-cop-fix
branch
2 times, most recently
from
5a1c01a
to
be9e2c2
Compare
ekohl
requested changes
Apr 5, 2024
archanaserver
force-pushed
the
style-cop-fix
branch
from
be9e2c2
to
cf2ac4f
Compare
archanaserver
force-pushed
the
style-cop-fix
branch
from
cf2ac4f
to
d2d0488
Compare
archanaserver
changed the title
archanaserver
force-pushed
the
style-cop-fix
branch
2 times, most recently
from
5eb0c44
to
10b87e3
Compare
|
Needs also a rebase now. |
archanaserver
force-pushed
the
style-cop-fix
branch
from
10b87e3
to
ef3b93d
Compare
archanaserver
force-pushed
the
style-cop-fix
branch
2 times, most recently
from
7b40dca
to
679ea28
Compare
14 tasks
This cop efficiently detects and fixes unnecessary variable assignments before returning values in methods. Also improves redability of code by reducing clutter. https://docs.rubocop.org/rubocop/cops_style.html#styleredundantassignment
This cop identifies and recommends removing redundant '.rb' file extensions specified in require and require_relative statements. Omitting the extension improves code clarity and adheres to Ruby's behavior. https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfileextensioninrequire
This cop ensures that optional keyword parameters are positioned at the end of the parameters list. This promotes readability by following the common convention of placing required parameters first and optional parameters last. https://docs.rubocop.org/rubocop/cops_style.html#stylekeywordparametersorder
archanaserver
force-pushed
the
style-cop-fix
branch
from
679ea28
to
a24a210
Compare
ehelms
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Style/RedundantAssignment & Style/RedundantFileExtensionInRequire cop.
Check commits for more details