Deploy the CA password file to ssl build directory #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
force-pushed
the
deploy-passwd-ssl-build
branch
from
e1fea43
to
535d201
Compare
ekohl
reviewed
Sep 22, 2023
|
Something appears to be very broken in the acceptance tests. |
|
I think we should ensure we are managing the build directory first -- #419 |
As the pki_dir is intended for deployment rather than generation, and the CA password file is needed primarily for certificate generation it should reside in the build directory.
ehelms
force-pushed
the
deploy-passwd-ssl-build
branch
from
535d201
to
08dac8e
Compare
ehelms
commented
Sep 22, 2023
| @@ -23,6 +23,10 @@ | |||
| String $ca_key_password = $certs::ca_key_password, | |||
| Stdlib::Absolutepath $ca_key_password_file = $certs::ca_key_password_file, | |||
| ) { | |||
| file { "${certs::pki_dir}/private/${default_ca_name}.pwd": | |||
| ensure => absent, | |||
| } | |||
ekohl
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the pki_dir is intended for deployment rather than generation, and the CA password file is needed primarily for certificate generation it should reside in the build directory.