Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade chromedriver to fix Circle job #1006

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Upgrade chromedriver to fix Circle job #1006

merged 2 commits into from
Sep 10, 2021

Conversation

cherewaty
Copy link
Collaborator

Motivation

Related to #1005

Approach

I don't love kicking this can down the road again, but I really don't want to block #1004 on this issue.

Need to follow up on

@interactors/html needs to drop its dependency on @bigtest/globals and @bigtest/performance. Caused some yarn.lock additions that should've already been in the v0 branch.

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2021

🦋 Changeset detected

Latest commit: 9a9c448

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@bigtest/webdriver Minor
@bigtest/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cherewaty cherewaty marked this pull request as ready for review September 9, 2021 23:39
@cowboyd
Copy link
Member

cowboyd commented Sep 10, 2021

@cherewaty The dependency on @bigtest/performance should be a no-brainer since it was implemented as a ponyfill for the web performance API in node. Since @interactors/html is browser-only, we can just drop the dependency and use https://developer.mozilla.org/en-US/docs/Web/API/Performance

The Performance interface provides access to performance-related information for the current page. It's part of the High Resolution Time API, but is enhanced by the Performance Timeline API, the Navigation Timing API, the User Timing API, and the Resource Timing API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants