Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying storage classes #777

Merged
merged 12 commits into from
Jun 14, 2024
Merged

Allow specifying storage classes #777

merged 12 commits into from
Jun 14, 2024

Conversation

rzvoncek
Copy link
Contributor

@rzvoncek rzvoncek commented Jun 12, 2024 •
edited
Loading

Fixes #568

@adejanovski adejanovski mentioned this pull request Jun 14, 2024
Open
adejanovski
adejanovski approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested changing the storage class in S3 which worked as expected ✅
Just a few small changes on docs and a typo and we're good to go

tests/integration/features/integration_tests.feature Outdated Show resolved Hide resolved
medusa-example.ini Outdated Show resolved Hide resolved
docs/Configuration.md Outdated Show resolved Hide resolved
@adejanovski adejanovski merged commit 6a56e53 into master Jun 14, 2024
6 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rzvoncek rzvoncek mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying storage class name when uploading backups to S3
4 participants
@rzvoncek @adejanovski @maburadeh @aburadeh