-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Grid Assesment #210
Conversation
- Also change tests
- Change tests as well
- Failed because it was on the boundary of accuracy
for more information, see https://pre-commit.ci
Added default BeckeWeights to aim_weights to all static, constructor methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ali-Tehrani.
- Shouldn't we make the
rgrid
infrom_pruned
method optional as well? - Thinking more after our discussion, I agree that we should remove
*_
in arguments. It seems to have been used arbitrarily and as we are not using it anywhere else, it is best to remove it for now. Can you please remove them?
The *_ is removed. If you're referring to AtomGrid.from_prune, default radial grid isn't added because atomic numbers is not included in its signature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed *
from the rest of AtomGrid class, which caused an API change (see cc61d59). If you have no further comments, feel free to merge this PR.
I did not find a way to add a commit to this PR. The only change that I would make is to substitute the values in line 198 of AtomGrid:
by the corresponding scipy constants
just for consistency with the molgrid module. |
- Happens multiple times, note test is randomized
This pull-requests addresses Issue #179.
The Default rgrid was obtained from Horton. This corresponds to using the UniformInteger grid and PowerRTransform with a "fine" preset for the angular component. This is stored in grid/utils.py in a dictionary with the following:
If the user provided rgrid as None, then it generates the default radial grid.
The following functions and their tests (with two added) were changed to have default rgrid options: