-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with PHP 8.4 #1039
Conversation
> League\OAuth2\Client\Provider\AbstractProvider::authorize(): Implicitly marking parameter $redirectHandler as nullable is deprecated, the explicit nullable type must be used instead
@ramsey Could you please approve the workflow? |
hi, running our internal PHP 8.4 compatibility checks and this abstract library emits a lot of deprecations for us so thank You very much for this PR :) is there any timeframe for release? |
@shadowhand Would you be able to help out? |
https://github.com/hwi/HWIOAuthBundle looks unmaintained so I'm looking for an alternative, but this repo looks unmaintained as well :( |
I decided to remove this dependency and do the OAuth dance with Google myself. Wasn't that hard. |
yeah, we probably will switch to JWT parsing and signature checking on backend only as well if this doesn't get pulled through |
I approved the workflow, but now there are a bunch of failures that appear unrelated to your change. I'll need to investigate and fix these. |
Let's remove all unsuppported versions (<8.1), to make it easier. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 191 193 +2
===========================================
Files 20 20
Lines 516 521 +5
===========================================
+ Hits 516 521 +5 |
When #1033 is merged, I will propose a PR to add PHP 8.4 to the matrix as well.