Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with PHP 8.4 #1039

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Make compatible with PHP 8.4 #1039

merged 2 commits into from
Dec 10, 2024

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Oct 31, 2024

League\OAuth2\Client\Provider\AbstractProvider::authorize(): Implicitly marking parameter $redirectHandler as nullable is deprecated, the explicit nullable type must be used instead

When #1033 is merged, I will propose a PR to add PHP 8.4 to the matrix as well.

> League\OAuth2\Client\Provider\AbstractProvider::authorize(): Implicitly marking parameter $redirectHandler as nullable is deprecated, the explicit nullable type must be used instead
@ruudk
Copy link
Contributor Author

ruudk commented Oct 31, 2024

@ramsey Could you please approve the workflow?

@carloscz
Copy link

carloscz commented Nov 14, 2024

hi, running our internal PHP 8.4 compatibility checks and this abstract library emits a lot of deprecations for us so thank You very much for this PR :) is there any timeframe for release?

@ruudk
Copy link
Contributor Author

ruudk commented Nov 15, 2024

@shadowhand Would you be able to help out?

@stephanvierkant
Copy link

https://github.com/hwi/HWIOAuthBundle looks unmaintained so I'm looking for an alternative, but this repo looks unmaintained as well :(

@ruudk
Copy link
Contributor Author

ruudk commented Nov 29, 2024

I decided to remove this dependency and do the OAuth dance with Google myself. Wasn't that hard.

@carloscz
Copy link

carloscz commented Nov 29, 2024

yeah, we probably will switch to JWT parsing and signature checking on backend only as well if this doesn't get pulled through

@ramsey
Copy link
Contributor

ramsey commented Dec 2, 2024

I approved the workflow, but now there are a bunch of failures that appear unrelated to your change. I'll need to investigate and fix these.

@stephanvierkant
Copy link

Let's remove all unsuppported versions (<8.1), to make it easier.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2455200) to head (268c0ea).
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              master     #1039   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       191       193    +2     
===========================================
  Files             20        20           
  Lines            516       521    +5     
===========================================
+ Hits             516       521    +5     

@ramsey ramsey merged commit a92f67e into thephpleague:master Dec 10, 2024
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants